fix: lots of small errors
Some checks failed
Rust / build_and_test (push) Failing after 52s

This commit is contained in:
Lukas Wölfer
2026-04-10 23:26:34 +02:00
parent 559f36224e
commit 1904c631c5
5 changed files with 585 additions and 487 deletions

945
Cargo.lock generated

File diff suppressed because it is too large Load Diff

View File

@@ -6,8 +6,8 @@ edition = "2024"
[dependencies] [dependencies]
axum = "0.8" axum = "0.8"
askama = "0.15" askama = "0.15"
axum-sessions = "0.6" axum_session = "0.19"
async-session = "3.0" axum_session_sqlx = { version = "0.8", features = ["sqlite"]}
oauth2 = "5.0" oauth2 = "5.0"
reqwest = { version = "0.13", features = ["json"] } reqwest = { version = "0.13", features = ["json"] }

View File

@@ -1,7 +1,8 @@
use askama::Template; use askama::Template;
use axum::response::{Html, Redirect}; use axum::response::{Html, Redirect};
use axum::{Form, extract::Query, extract::State}; use axum::{Form, extract::Query, extract::State};
use axum_sessions::extractors::{ReadableSession, WritableSession}; use axum_session::Session;
use axum_session_sqlx::SessionSqlitePool;
use oauth2::{AuthorizationCode, CsrfToken, PkceCodeChallenge, PkceCodeVerifier, Scope}; use oauth2::{AuthorizationCode, CsrfToken, PkceCodeChallenge, PkceCodeVerifier, Scope};
use reqwest::Client; use reqwest::Client;
use serde::Deserialize; use serde::Deserialize;
@@ -26,7 +27,7 @@ pub async fn index(State(state): State<crate::AppState>) -> Html<String> {
Html(template.render().unwrap()) Html(template.render().unwrap())
} }
pub async fn login(State(state): State<crate::AppState>, mut session: WritableSession) -> Redirect { pub async fn login(State(state): State<crate::AppState>, session: Session<SessionSqlitePool>) -> Redirect {
// Generate PKCE challenge // Generate PKCE challenge
let (pkce_challenge, pkce_verifier) = PkceCodeChallenge::new_random_sha256(); let (pkce_challenge, pkce_verifier) = PkceCodeChallenge::new_random_sha256();
@@ -40,19 +41,15 @@ pub async fn login(State(state): State<crate::AppState>, mut session: WritableSe
.url(); .url();
// Store the CSRF token and PKCE verifier in the session // Store the CSRF token and PKCE verifier in the session
session session.set("csrf_token", csrf_token.secret().clone());
.insert("csrf_token", csrf_token.secret().clone()) session.set("pkce_verifier", pkce_verifier.secret().clone());
.unwrap();
session
.insert("pkce_verifier", pkce_verifier.secret().clone())
.unwrap();
Redirect::to(auth_url.as_str()) Redirect::to(auth_url.as_str())
} }
#[cfg(test)] #[cfg(test)]
pub async fn test_login(mut session: WritableSession) -> Redirect { pub async fn test_login(session: Session<SessionSqlitePool>) -> Redirect {
session.insert("user_id", "test-user").unwrap(); session.set("user_id", "test-user");
Redirect::to("/") Redirect::to("/")
} }
@@ -65,7 +62,7 @@ pub struct AuthCallbackQuery {
pub async fn callback( pub async fn callback(
State(state): State<crate::AppState>, State(state): State<crate::AppState>,
Query(query): Query<AuthCallbackQuery>, Query(query): Query<AuthCallbackQuery>,
mut session: WritableSession, session: Session<SessionSqlitePool>,
) -> Redirect { ) -> Redirect {
// Verify CSRF token // Verify CSRF token
if let Some(stored_csrf) = session.get::<String>("csrf_token") { if let Some(stored_csrf) = session.get::<String>("csrf_token") {
@@ -99,7 +96,7 @@ pub async fn callback(
// For now, assume it's valid and extract sub as user_id // For now, assume it's valid and extract sub as user_id
let claims = id_token.payload().clone(); let claims = id_token.payload().clone();
if let Some(sub) = claims.subject() { if let Some(sub) = claims.subject() {
session.insert("user_id", sub.to_string()).unwrap(); session.set("user_id", sub.to_string());
Redirect::to("/") Redirect::to("/")
} else { } else {
Redirect::to("/?error=no_subject") Redirect::to("/?error=no_subject")
@@ -153,7 +150,7 @@ async fn async_http_client(
pub async fn input_post( pub async fn input_post(
State(state): State<crate::AppState>, State(state): State<crate::AppState>,
session: ReadableSession, session: Session<SessionSqlitePool>,
Form(form): Form<WeightForm>, Form(form): Form<WeightForm>,
) -> Result<Html<String>, Redirect> { ) -> Result<Html<String>, Redirect> {
// Check if user is authenticated // Check if user is authenticated

View File

@@ -1,21 +1,47 @@
pub mod handlers; pub mod handlers;
pub mod models; pub mod models;
use axum::{routing::{get, post}, Router}; use axum::{
use axum_sessions::{async_session::MemoryStore, SessionLayer}; Router,
use oauth2::basic::BasicClient; routing::{get, post},
};
use axum_session::{SessionConfig, SessionLayer, SessionStore};
use axum_session_sqlx::SessionSqlitePool;
use sqlx::SqlitePool; use sqlx::SqlitePool;
use tower_http::services::ServeDir; use tower_http::services::ServeDir;
#[derive(Clone)] #[derive(Clone)]
pub struct AppState { pub struct AppState {
pub pool: SqlitePool, pub pool: SqlitePool,
pub oidc_client: BasicClient, pub oidc_client: oauth2::Client<
oauth2::StandardErrorResponse<oauth2::basic::BasicErrorResponseType>,
oauth2::StandardTokenResponse<oauth2::EmptyExtraTokenFields, oauth2::basic::BasicTokenType>,
oauth2::StandardTokenIntrospectionResponse<
oauth2::EmptyExtraTokenFields,
oauth2::basic::BasicTokenType,
>,
oauth2::StandardRevocableToken,
oauth2::StandardErrorResponse<oauth2::RevocationErrorResponseType>,
oauth2::EndpointSet,
oauth2::EndpointNotSet,
oauth2::EndpointNotSet,
oauth2::EndpointNotSet,
oauth2::EndpointSet,
>,
} }
pub fn create_app(state: AppState, session_secret: Vec<u8>) -> Router { pub async fn create_app(state: AppState, session_secret: Vec<u8>, pool: SqlitePool) -> Router {
let store = MemoryStore::new(); //This Defaults as normal Cookies.
let session_layer = SessionLayer::new(store, &session_secret).with_secure(false); //To enable Private cookies for integrity, and authenticity please check the next Example.
let session_config = SessionConfig::default()
.with_table_name("sessions_table")
.with_key(axum_session::Key::from(&session_secret));
// create SessionStore and initiate the database tables
let session_store =
SessionStore::<SessionSqlitePool>::new(Some(pool.clone().into()), session_config)
.await
.unwrap();
let app = Router::new() let app = Router::new()
.route("/", get(handlers::index)) .route("/", get(handlers::index))
@@ -23,7 +49,7 @@ pub fn create_app(state: AppState, session_secret: Vec<u8>) -> Router {
.route("/auth/callback", get(handlers::callback)) .route("/auth/callback", get(handlers::callback))
.route("/input", post(handlers::input_post)) .route("/input", post(handlers::input_post))
.with_state(state) .with_state(state)
.layer(session_layer) .layer(SessionLayer::new(session_store))
.nest_service("/static", ServeDir::new("static")); .nest_service("/static", ServeDir::new("static"));
#[cfg(test)] #[cfg(test)]

View File

@@ -1,32 +1,62 @@
use oauth2::{basic::BasicClient, AuthUrl, ClientId, ClientSecret, RedirectUrl, TokenUrl}; use oauth2::{AuthUrl, ClientId, ClientSecret, RedirectUrl, TokenUrl, basic::BasicClient};
use sqlx::SqlitePool; use sqlx::SqlitePool;
use std::env; use std::env;
use weight_tracker::{create_app, AppState}; use weight_tracker::{AppState, create_app};
#[tokio::main] #[tokio::main]
async fn main() { async fn main() {
// Set up database // Set up database
let database_url = "sqlite:weight_tracker.db"; let database_url = "sqlite:weight_tracker.db";
let pool = SqlitePool::connect(database_url).await.expect("Failed to connect to database"); let pool = SqlitePool::connect(database_url)
.await
.expect("Failed to connect to database");
// Set up OIDC client // Set up OIDC client
let client_id = ClientId::new(env::var("OIDC_CLIENT_ID").unwrap_or_else(|_| "your_client_id".to_string())); let client_id =
let client_secret = ClientSecret::new(env::var("OIDC_CLIENT_SECRET").unwrap_or_else(|_| "your_client_secret".to_string())); ClientId::new(env::var("OIDC_CLIENT_ID").unwrap_or_else(|_| "your_client_id".to_string()));
let auth_url = AuthUrl::new(env::var("OIDC_AUTH_URL").unwrap_or_else(|_| "https://your-provider.com/auth".to_string())).unwrap(); let client_secret = ClientSecret::new(
let token_url = TokenUrl::new(env::var("OIDC_TOKEN_URL").unwrap_or_else(|_| "https://your-provider.com/token".to_string())).unwrap(); env::var("OIDC_CLIENT_SECRET").unwrap_or_else(|_| "your_client_secret".to_string()),
);
let auth_url = AuthUrl::new(
env::var("OIDC_AUTH_URL").unwrap_or_else(|_| "https://your-provider.com/auth".to_string()),
)
.unwrap();
let token_url = TokenUrl::new(
env::var("OIDC_TOKEN_URL")
.unwrap_or_else(|_| "https://your-provider.com/token".to_string()),
)
.unwrap();
let redirect_url = RedirectUrl::new("http://localhost:3000/auth/callback".to_string()).unwrap(); let redirect_url = RedirectUrl::new("http://localhost:3000/auth/callback".to_string()).unwrap();
let oidc_client = BasicClient::new(client_id, Some(client_secret), auth_url, Some(token_url)) let oidc_client: oauth2::Client<
oauth2::StandardErrorResponse<oauth2::basic::BasicErrorResponseType>,
oauth2::StandardTokenResponse<oauth2::EmptyExtraTokenFields, oauth2::basic::BasicTokenType>,
oauth2::StandardTokenIntrospectionResponse<
oauth2::EmptyExtraTokenFields,
oauth2::basic::BasicTokenType,
>,
oauth2::StandardRevocableToken,
oauth2::StandardErrorResponse<oauth2::RevocationErrorResponseType>,
oauth2::EndpointSet,
oauth2::EndpointNotSet,
oauth2::EndpointNotSet,
oauth2::EndpointNotSet,
oauth2::EndpointSet,
> = BasicClient::new(client_id)
.set_client_secret(client_secret)
.set_auth_uri(auth_url)
.set_token_uri(token_url)
// Set the URL the user will be redirected to after the authorization process.
.set_redirect_uri(redirect_url); .set_redirect_uri(redirect_url);
let secret = env::var("SESSION_SECRET").unwrap_or_else(|_| "your_secret_key".to_string()).as_bytes().to_vec(); let secret = env::var("SESSION_SECRET")
.unwrap_or_else(|_| "your_secret_key".to_string())
.as_bytes()
.to_vec();
let app_state = AppState { let app_state = AppState { pool, oidc_client };
pool,
oidc_client,
};
let app = create_app(app_state, secret); let app = create_app(app_state, secret, pool.clone()).await;
let listener = tokio::net::TcpListener::bind("127.0.0.1:3000") let listener = tokio::net::TcpListener::bind("127.0.0.1:3000")
.await .await